Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The delete_stale_pid_file check for the daemon is fragile #5933

Open
sphuber opened this issue Mar 16, 2023 · 0 comments
Open

The delete_stale_pid_file check for the daemon is fragile #5933

sphuber opened this issue Mar 16, 2023 · 0 comments

Comments

@sphuber
Copy link
Contributor

sphuber commented Mar 16, 2023

The aiida.cmdline.utils.daemon.delete_stale_pid_file was added to automatically detect and clean up stale PID files for the daemon. However, it is kind of fragile as it does not take into account that the PID file might be on a shared file system and the daemon was actually started from a different machine with access to the same file system. Ideally, the hostname could be included in the PID file to try and distinguish this case, in which case an error should be raised instead of removing the PID file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant