Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest follow-up #3659

Closed
4 tasks done
ltalirz opened this issue Dec 13, 2019 · 3 comments · Fixed by #3715
Closed
4 tasks done

pytest follow-up #3659

ltalirz opened this issue Dec 13, 2019 · 3 comments · Fixed by #3715

Comments

@ltalirz
Copy link
Member

ltalirz commented Dec 13, 2019

This is a to-do list of things to complete, following the switch to pytest for testing

  • Update documentation & wiki (verdi devel tests => pytest)
  • Fix (py)test warnings (will touch lots of files)
  • Move test files out of aiida-core inside top-level tests/ folder
  • Decide whether we need to improve test discovery (see comment)

Then, over time, where it makes sense, we should start moving existing tests from the AiiDATestCase to pytest (e.g. where pytest fixtures are making things more effective)

@ltalirz ltalirz changed the title pytest follo-up pytest follow-up Dec 13, 2019
@ltalirz ltalirz self-assigned this Dec 13, 2019
@greschd greschd self-assigned this Dec 16, 2019
@greschd
Copy link
Member

greschd commented Dec 16, 2019

I'll have a look at the test discovery part (i.e., fixing the backend variable when an external test profile is used).

@ltalirz
Copy link
Member Author

ltalirz commented Dec 19, 2019

With #3685 merged, only moving the tests out to a separate folder remains.
Since this will likely affect almost any PR and there are still many PRs open, I propose we set a date for this move and let people know.

@sphuber Would you agree? How about some date mid-January?

@greschd
Copy link
Member

greschd commented Dec 19, 2019

If we're only renaming files, git should be able to automatically merge in most cases (unless the file content is changed so much in the branch it doesn't recognize it as the same file) -- so that should be pretty painless even for existing PRs.

Still probably makes sense to be cautious and announce it in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants