test(api): else cases for bind.ts

Author: aidenybai

src/core/directives/__test__/bind.spec.ts

@@ -134,4 +134,74 @@ describe('.bindDirective', () => {
     expect(el.title).toEqual('test');
     expect(el.translate).toEqual(null);
   });
+
+  it('should accept string format for attributes', () => {
+    const el = document.createElement('a');
+    const expression = 'foo';
+    const state = { foo: expression };
+    bindDirective({
+      el,
+      parts: ['bind', 'title'],
+      data: {
+        value: expression,
+        compute: compute(expression, el),
+        deps: ['title'],
+      },
+      state,
+    });
+    expect(el.getAttribute('title')).toEqual('foo');
+  });
+
+  it('should remove attribute if no value apparent', () => {
+    const el = document.createElement('a');
+    const expression = '';
+    const state = {};
+    bindDirective({
+      el,
+      parts: ['bind', 'title'],
+      data: {
+        value: expression,
+        compute: compute(expression, el),
+        deps: ['title'],
+      },
+      state,
+    });
+    expect(el.hasAttribute('title')).toEqual(false);
+  });
+
+  it('should remove class attribute if no classes apparent', () => {
+    const el = document.createElement('a');
+    const expression = `{}`;
+    const state = {};
+    bindDirective({
+      el,
+      parts: ['bind', 'class'],
+      data: {
+        value: expression,
+        compute: compute(expression, el),
+        deps: [],
+      },
+      state,
+    });
+    expect(el.className).toEqual('');
+    expect(el.hasAttribute('class')).toEqual(false);
+  });
+
+  it('should remove style attribute if no styles apparent', () => {
+    const el = document.createElement('a');
+    el.setAttribute('style', '');
+    const expression = `{}`;
+    const state = {};
+    bindDirective({
+      el,
+      parts: ['bind', 'style'],
+      data: {
+        value: expression,
+        compute: compute(expression, el),
+        deps: [],
+      },
+      state,
+    });
+    expect(el.hasAttribute('style')).toEqual(false);
+  });
 });

src/core/directives/bind.ts

@@ -30,7 +30,6 @@ export const bindDirective = ({ el, parts, data, state }: DirectiveProps): void
         } else if (formatAcceptableWhitespace(rawClasses).length > 0) {
           el.className = formatAcceptableWhitespace(rawClasses);
         } else {
-          /* istanbul ignore next */
           el.className = '';
           el.removeAttribute('class');
         }
@@ -41,7 +40,6 @@ export const bindDirective = ({ el, parts, data, state }: DirectiveProps): void
     case 'style': {
       // Accept object and set properties based on boolean state value
       const styles = data.compute(state);
-      /* istanbul ignore next */
       if (el.hasAttribute('style')) el.removeAttribute('style');
       Object.entries(styles).forEach(([styleName, styleValue]) => {
         el.style[styleName] = styleValue;
@@ -53,7 +51,6 @@ export const bindDirective = ({ el, parts, data, state }: DirectiveProps): void
       const attributes = data.compute(state);
 
       // Allow object syntax in binding without modifier
-      /* istanbul ignore else */
       if (typeof attributes === 'object' && attributes !== null) {
         Object.entries(attributes).forEach(([name, value]) => {
           // Only set attr if not falsy