Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read edm4hep #1371

Merged
merged 26 commits into from
Jan 20, 2025
Merged

Read edm4hep #1371

merged 26 commits into from
Jan 20, 2025

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Dec 13, 2024 •
edited
Loading

BEGINRELEASENOTES

ENDRELEASENOTES

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Test Results

   16 files     16 suites   5h 59m 50s ⏱️
  370 tests   367 ✅ 0 💤 3 ❌
2 905 runs  2 896 ✅ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit 2c6f463.

♻️ This comment has been updated with latest results.

@andresailer andresailer marked this pull request as ready for review December 17, 2024 16:18
@andresailer
Copy link
Member Author

That GeneratorInfo is not yet written to EDM4hep files?

@tmadlener
Copy link
Contributor

That GeneratorInfo is not yet written to EDM4hep files?

Not consistently, i.e. if at all currently only with files that are produced via k4GeneratorsConfig. So I think we have to consider that effectively optional at this point, until that has become more prevalent. Additionally, there are still some changes pending, so maybe we should consider postponing that here in any case?

tmadlener
tmadlener reviewed Dec 18, 2024
View reviewed changes
@andresailer andresailer force-pushed the readEDM4hep branch 2 times, most recently from 3beea52 to 60603ac Compare December 18, 2024 14:29
@andresailer andresailer force-pushed the readEDM4hep branch 2 times, most recently from 1a9cace to 5906930 Compare January 8, 2025 17:06
tmadlener
tmadlener reviewed Jan 9, 2025
View reviewed changes
jmcarcell
jmcarcell reviewed Jan 17, 2025
View reviewed changes
tmadlener
tmadlener reviewed Jan 20, 2025
View reviewed changes
tmadlener
tmadlener reviewed Jan 20, 2025
View reviewed changes
@andresailer @tmadlener
ReadEDM4hep: correct cmake status message about requirements.
2c6f463 
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
tmadlener
tmadlener approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, now.

@andresailer andresailer merged commit 46ce8f7 into AIDASoft:master Jan 20, 2025
12 of 16 checks passed
@andresailer andresailer deleted the readEDM4hep branch January 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc left review comments

@jmcarcell jmcarcell jmcarcell left review comments

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create EDM4hep reader for DDG4
4 participants
@andresailer @tmadlener @wdconinc @jmcarcell