By default do not keep hash string for detector checksum #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
As pointed out in Issue DetectorChecksum memory consumption scales with complexity (and maxes out...) #1143 keeping the hash string of detector
components is very often too resource/memory consuming. Hence keep the hashed strings only if requested
e.g. for debugging purposes. By default the hash strings are not kept.
This means the produces hash sums are NOT backwards compatible, because during the checksum creation the
hash strings from sub-components were used. These are now consequently replaced by the corresponding hash codes.
ENDRELEASENOTES