Skip to content

Commit 8c30c82

Browse files
committed
release: work around GitHub Actions weirdness
1 parent c44d263 commit 8c30c82

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

RELEASE-CHECKLIST.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,11 @@ Release Checklist
2626
`cargo update -p ripgrep` so that the `Cargo.lock` is updated. Commit the
2727
changes and create a new signed tag. Alternatively, use
2828
`cargo-up --no-push --no-release Cargo.toml {VERSION}` to automate this.
29-
* Push changes to GitHub, including the tag. (But do not publish new version of
30-
ripgrep to crates.io yet.)
29+
* Push changes to GitHub, NOT including the tag. (But do not publish new
30+
version of ripgrep to crates.io yet.)
31+
* Once CI for `master` finishes successfully, push the version tag. (Trying to
32+
do this in one step seems to result in GitHub Actions not seeing the tag
33+
push and thus not running the release workflow.)
3134
* Wait for CI to finish creating the release. If the release build fails, then
3235
delete the tag from GitHub, make fixes, re-tag, delete the release and push.
3336
* Copy the relevant section of the CHANGELOG to the tagged release notes.

0 commit comments

Comments
 (0)