Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass aepp origin to wallet callbacks #918

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Conversation

davidyuk
Copy link
Member

supposed to fix #917

@davidyuk davidyuk requested a review from nduchak February 25, 2020 08:58
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #918 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #918      +/-   ##
===========================================
+ Coverage    92.73%   92.79%   +0.06%     
===========================================
  Files           57       57              
  Lines         2944     2944              
===========================================
+ Hits          2730     2732       +2     
+ Misses         214      212       -2
Impacted Files Coverage Δ
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 98.96% <100%> (ø) ⬆️
es/utils/keystore.js 100% <100%> (ø) ⬆️
es/rpc/server.js 100% <100%> (ø) ⬆️
es/utils/aepp-wallet-communication/rpc/aepp-rpc.js 100% <100%> (ø) ⬆️
...communication/connection/browser-window-message.js 100% <100%> (ø) ⬆️
es/channel/handlers.js 80.18% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173b761...4a1e5fc. Read the comment docs.

# Conflicts:
#	es/utils/aepp-wallet-communication/helpers.js
#	examples/browser/vuejs/connect-two-ae/identity/src/components/Home.vue
@nduchak nduchak merged commit 56b3dcb into develop Feb 25, 2020
@nduchak nduchak deleted the feature/persist-origin branch February 25, 2020 12:59
@nduchak nduchak mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to get the domain of aepp running in iframe?
2 participants