Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Remove-aepp-rpc-client-from-wallet #912

Merged
merged 6 commits into from
Feb 25, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Feb 21, 2020

No description provided.

@nduchak nduchak added the enhancement New feature or request label Feb 21, 2020
@nduchak nduchak self-assigned this Feb 21, 2020
@nduchak
Copy link
Contributor Author

nduchak commented Feb 21, 2020

Resolve #906

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #912 into develop will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #912      +/-   ##
===========================================
+ Coverage    92.71%   93.03%   +0.32%     
===========================================
  Files           57       57              
  Lines         2936     2944       +8     
===========================================
+ Hits          2722     2739      +17     
+ Misses         214      205       -9     
Impacted Files Coverage Δ
es/channel/internal.js 96.09% <0.00%> (+0.78%) ⬆️
es/channel/handlers.js 80.18% <0.00%> (+0.90%) ⬆️
es/utils/json-big.js 84.13% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdb4b4...d0e4cce. Read the comment docs.

Copy link
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think addRpcClient should expose generated id to be able to pass it to removeClient.

@nduchak nduchak added this to the 7.1.0 milestone Feb 24, 2020
@nduchak nduchak merged commit e5281ba into develop Feb 25, 2020
@nduchak nduchak deleted the feat/aex-2-ability-to-remove-aepp branch February 25, 2020 10:01
@nduchak nduchak mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants