-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Remove-aepp-rpc-client-from-wallet #912
Conversation
Resolve #906 |
Codecov Report
@@ Coverage Diff @@
## develop #912 +/- ##
===========================================
+ Coverage 92.71% 93.03% +0.32%
===========================================
Files 57 57
Lines 2936 2944 +8
===========================================
+ Hits 2722 2739 +17
+ Misses 214 205 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think addRpcClient
should expose generated id to be able to pass it to removeClient
.
Return `clientId` in `addRpcClient` Add test's
…p' into feat/aex-2-ability-to-remove-aepp
No description provided.