Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Signing): Message Signing #903

Merged
merged 11 commits into from
Feb 19, 2020
Merged

Feat(Signing): Message Signing #903

merged 11 commits into from
Feb 19, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Feb 17, 2020

No description provided.

@nduchak nduchak added this to the 7.1.0 milestone Feb 17, 2020
@nduchak nduchak requested a review from mradkov February 17, 2020 16:29
@nduchak nduchak self-assigned this Feb 17, 2020
@nduchak
Copy link
Contributor Author

nduchak commented Feb 17, 2020

Resolve #904

@codecov
Copy link

codecov bot commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #903 into develop will increase coverage by 11.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #903       +/-   ##
============================================
+ Coverage    80.86%   92.70%   +11.83%     
============================================
  Files           57       57               
  Lines         2969     2935       -34     
============================================
+ Hits          2401     2721      +320     
+ Misses         568      214      -354
Impacted Files Coverage Δ
es/ae/wallet.js 100.00% <0.00%> (ø) ⬆️
es/index.js 100.00% <0.00%> (ø) ⬆️
es/ae/aepp.js 100.00% <0.00%> (ø) ⬆️
es/utils/json-big.js 81.25% <0.00%> (+0.48%) ⬆️
es/contract/compiler.js 100.00% <0.00%> (+2.08%) ⬆️
es/utils/crypto.js 85.47% <0.00%> (+5.12%) ⬆️
es/tx/tx.js 100.00% <0.00%> (+14.45%) ⬆️
es/channel/internal.js 95.31% <0.00%> (+60.14%) ⬆️
es/channel/handlers.js 79.27% <0.00%> (+67.03%) ⬆️
es/channel/index.js 88.54% <0.00%> (+74.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f877ea0...13e11f7. Read the comment docs.

@nduchak nduchak force-pushed the feat/add-arbitrary-data-sign branch from 366055d to 4e84a26 Compare February 18, 2020 13:25
@nduchak
Copy link
Contributor Author

nduchak commented Feb 18, 2020

Resolve #902, #899, aeternity/tipwallet#87

mradkov
mradkov approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thepiwo
thepiwo approved these changes Feb 19, 2020
View reviewed changes
Copy link
Collaborator

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change to signing hashed personal message!

@nduchak nduchak merged commit bc739b4 into develop Feb 19, 2020
@nduchak nduchak deleted the feat/add-arbitrary-data-sign branch February 20, 2020 12:02
@mradkov mradkov mentioned this pull request Feb 21, 2020
Closed
@davidyuk davidyuk mentioned this pull request Feb 24, 2020
Closed
@nduchak nduchak mentioned this pull request Feb 25, 2020
Merged
@davidyuk davidyuk mentioned this pull request Mar 1, 2021
Closed
@mradkov mradkov mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidyuk davidyuk davidyuk left review comments

@mradkov mradkov mradkov approved these changes

@thepiwo thepiwo thepiwo approved these changes

Assignees

@nduchak nduchak

Labels
feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nduchak @thepiwo @davidyuk @mradkov