Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transferFunds: Accept onAccount option #1060

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

davidyuk
Copy link
Member

closes #1046

@davidyuk davidyuk changed the title transferFunds: Accept on account option transferFunds: Accept onAccount option Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@38abe52). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1060   +/-   ##
==========================================
  Coverage           ?   93.62%           
==========================================
  Files              ?       58           
  Lines              ?     2949           
  Branches           ?        0           
==========================================
  Hits               ?     2761           
  Misses             ?      188           
  Partials           ?        0           
Impacted Files Coverage Δ
es/chain/index.js 100.00% <ø> (ø)
es/ae/index.js 100.00% <100.00%> (ø)
es/tx/tx.js 96.42% <100.00%> (ø)
es/tx/validator.js 100.00% <100.00%> (ø)
es/utils/swagger.js 81.57% <0.00%> (ø)
es/utils/json-big.js 100.00% <0.00%> (ø)
es/contract/index.js 100.00% <0.00%> (ø)
es/tx/builder/schema.js 96.35% <0.00%> (ø)
es/ae/oracle.js 98.07% <0.00%> (ø)
es/contract/ga/index.js 100.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38abe52...9207280. Read the comment docs.

@davidyuk davidyuk force-pushed the feature/transfer-founds-on-account branch from b4c692a to 0394986 Compare July 16, 2020 14:35
@davidyuk davidyuk marked this pull request as ready for review July 16, 2020 15:10
@davidyuk davidyuk added this to the 7.7.0 milestone Aug 11, 2020
@davidyuk davidyuk force-pushed the feature/transfer-founds-on-account branch from 0394986 to 9207280 Compare August 16, 2020 08:14
@davidyuk davidyuk merged commit d4aee2a into develop Aug 16, 2020
@davidyuk davidyuk deleted the feature/transfer-founds-on-account branch August 16, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transferFunds: Implement support of onAccount option
2 participants