minor fixes and changes

Author: maleck13

Makefile

@@ -7,7 +7,7 @@ SHELL = /bin/bash
 LDFLAGS=-ldflags "-w -s -X main.Version=${TAG}"
 
 
-build:
+build: test-unit
 	go build -o mobile ./cmd/mobile
 
 build_linux:

pkg/cmd/clients.go

@@ -2,8 +2,8 @@ package cmd
 
 import (
 	"fmt"
-	"strings"
 	"io"
+	"strings"
 
 	"github.com/aerogear/mobile-cli/pkg/apis/mobile/v1alpha1"
 	mobile "github.com/aerogear/mobile-cli/pkg/client/mobile/clientset/versioned"
@@ -71,6 +71,7 @@ func (cc *ClientCmd) GetClientCmd() *cobra.Command {
 kubectl plugin mobile get client <clientID>
 oc plugin mobile get client <clientID>`,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			fmt.Println(args, len(args))
 			if len(args) != 1 {
 				return errors.New("missing argument <clientID>")
 			}

pkg/cmd/clients_test.go

@@ -154,7 +154,7 @@ func TestGetClient(t *testing.T) {
 			ClientName:   "",
 			Flags:        []string{"--namespace=myproject", "-o=json"},
 			ExpectError:  true,
-			ErrorPattern: "^failed to get mobile client with clientID (\\w+)+:.*",
+			ErrorPattern: "^missing argument .*",
 		},
 	}
 	for _, tc := range cases {

pkg/cmd/services.go

@@ -41,6 +41,7 @@ func (sc *ServicesCmd) ListServicesCmd() *cobra.Command {
 		Short: "get mobile aware services that can be provisioned to your namespace",
 		RunE: func(cmd *cobra.Command, args []string) error {
 			scList, err := sc.scClient.ServicecatalogV1beta1().ClusterServiceClasses().List(metav1.ListOptions{})
+			fmt.Println("sclist", scList, err)
 			if err != nil {
 				return errors.Wrap(err, "failed to list service classes")
 			}

pkg/cmd/services_test.go

@@ -82,12 +82,6 @@ func TestServicesCmd_ListServicesCmd(t *testing.T) {
 				return fakeClient
 			},
 			ExpectError: true,
-			Validate: func(t *testing.T, output []byte) {
-				err := string(output)
-				if err == "" {
-					t.Fatal("expected an error message but got none")
-				}
-			},
 		},
 	}