Upgrade Android, Gradle and Kotlin versions #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dimamo5
commented
Mar 16, 2021
dimamo5
commented
- Upgrades Android to version 11 (12e7fb3). This requires a bump in Robolectric. Unfortunately, Robolectric requires JDK9+ to test in Android 10+ (see What is the point in mandating for Java 9 to support Android Q. robolectric/robolectric#5258 (comment)), so I also upgraded the version used in CI to JDK 11.
- Upgrades Kotlin to the latest version (7498d5b)
- Upgrades Gradle to the latest version (8952342). Had to migrate our publish plugin.
- Migrates sample app to AndroidX (5449539).
Requires migrating publish task
Robolectric requires JDK > 9, so this PR bump the CI to run with JDK 11
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 6 6
Lines 117 117
Branches 19 19
======================================
Misses 117 117 Continue to review full report at Codecov.
|
|
#38 broke code coverage. Upgrading the codecov action didn't help 🤷♂️ I'll follow-up in a different PR. |
Fixes possible crashes in Android 11. See https://square.github.io/okhttp/changelog_3x/
dimamo5
force-pushed
the
upgrade-android-version
branch
from
1539fbc to
99a7590
Compare
Merged
thyandrecardoso
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.