Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite multiple PPI params at once #390

Closed
barthoekstra opened this issue May 17, 2020 · 3 comments
Closed

Composite multiple PPI params at once #390

barthoekstra opened this issue May 17, 2020 · 3 comments
Labels
Milestone

Comments

@barthoekstra
Copy link
Collaborator

Currently the composite_ppi() function only composites PPIs for a single parameter.

I need to make composites of a bunch of parameters stored in some PPIs, which obviously I'd like to do all at once rather than separately and then rebuilding a single composite PPI. So I've tweaked the composite function to accept a vector of param names (similar to how param selection in read_pvolfile() works) and a vector of method names to set methods per parameter type (if necessary).

As this is a ‘prototype’ function, I was wondering if you're interested in including this functionality (if you're not already working on it anyways). If so, even though I'm not 100% sure I'll end up using it myself, I could contribute and improve my existing code to make composite PPIs of multiple parameters.

@adokter
Copy link
Owner

adokter commented May 18, 2020

Hey @barthoekstra, yes this would be very useful and was on the todo-list, so please make a PR, thanks!

@barthoekstra
Copy link
Collaborator Author

Ok. Work in progress.

@adokter adokter added the sprint label May 27, 2021
@peterdesmet peterdesmet added this to the 0.6.0 milestone May 28, 2021
@adokter
Copy link
Owner

adokter commented Jun 11, 2021

closed by #393

@adokter adokter closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants