Skip to content

Commit 400f6ae

Browse files
committed
Fix linting
1 parent ed46ce3 commit 400f6ae

File tree

4 files changed

+1
-4
lines changed

4 files changed

+1
-4
lines changed

pkg/resources/kafka/configmap.go

-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ func (r *Reconciler) configCCMetricsReporter(broker v1beta1.Broker, config *prop
152152
func configureBrokerKRaftMode(bConfig *v1beta1.BrokerConfig, brokerID int32, kafkaCluster *v1beta1.KafkaCluster, config *properties.Properties,
153153
quorumVoters []string, serverPasses map[string]string, extListenerStatuses, intListenerStatuses map[string]v1beta1.ListenerStatusList, log logr.Logger,
154154
brokerReadOnlyConfig *properties.Properties) {
155-
156155
controllerListenerName := generateControlPlaneListener(kafkaCluster.Spec.ListenersConfig.InternalListeners)
157156

158157
// when kRaft is enabled for the cluster, brokers can still be configured to use zookeeper for metadata.

pkg/resources/kafka/configmap_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ zookeeper.connect=example.zk:2181/`,
722722

723723
// TestGenerateBrokerConfigKRaftMode serves as an aggregated test on top of TestGenerateBrokerConfig to verify basic broker configurations under KRaft mode
724724
// Note: most of the test cases under TestGenerateBrokerConfig are not replicated here since running KRaft mode doesn't affect things like SSL and storage configurations
725-
func TestGenerateBrokerConfigKRaftMode(t *testing.T) {
725+
func TestGenerateBrokerConfigKRaftMode(t *testing.T) { //nolint funlen
726726
testCases := []struct {
727727
testName string
728728
brokers []v1beta1.Broker

pkg/resources/kafka/kafka.go

-1
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ func (r *Reconciler) Reconcile(log logr.Logger) error {
366366
if r.KafkaCluster.Spec.KRaftMode {
367367
// all broker nodes under the same Kafka cluster must use the same cluster UUID
368368
if r.KafkaCluster.Status.ClusterID == "" {
369-
370369
// CLUSTER_ID can be overridden with ENV (e.g for migration from ZK to KRaft so it matches the value for ZK cluster)
371370
for _, env := range r.KafkaCluster.Spec.Envs {
372371
if env.Name == "CLUSTER_ID" {

pkg/resources/kafka/pod.go

-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ fi`},
131131
if r.KafkaCluster.Spec.KRaftMode {
132132
for i, container := range pod.Spec.Containers {
133133
if container.Name == kafkaContainerName {
134-
135134
// in KRaft mode, all broker nodes within the same Kafka cluster need to use the same cluster ID to format the storage
136135
addClusterIdEnv(r, pod, i)
137136

0 commit comments

Comments
 (0)