Skip to content

Commit 32828b9

Browse files
authored
Set KafkaUser as owner for its corresponding Certificate object
1 parent 8b28f39 commit 32828b9

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

pkg/pki/certmanagerpki/certmanager_user.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ func (c *certManager) clusterCertificateForUser(
147147
user *v1alpha1.KafkaUser, clusterDomain string) *certv1.Certificate {
148148
caName, caKind := c.getCA(user)
149149
cert := &certv1.Certificate{
150-
ObjectMeta: templates.ObjectMetaWithCustomNamespaceAndWithoutLabels(user.GetName(), user.GetNamespace(), c.cluster),
150+
ObjectMeta: templates.ObjectMetaWithKafkaUserOwnerAndWithoutLabels(user.GetName(), user),
151151
Spec: certv1.CertificateSpec{
152152
SecretName: user.Spec.SecretName,
153153
PrivateKey: &certv1.CertificatePrivateKey{

pkg/resources/templates/templates.go

+8-7
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package templates
1717
import (
1818
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1919

20+
"github.com/banzaicloud/koperator/api/v1alpha1"
2021
"github.com/banzaicloud/koperator/api/v1beta1"
2122
"github.com/banzaicloud/koperator/pkg/util"
2223
)
@@ -40,17 +41,17 @@ func ObjectMeta(name string, labels map[string]string, cluster *v1beta1.KafkaClu
4041
}
4142
}
4243

43-
// ObjectMetaWithCustomNamespaceAndWithoutLabels returns a metav1.ObjectMeta object with custom namespace, ownerReference and name
44-
func ObjectMetaWithCustomNamespaceAndWithoutLabels(name, namespace string, cluster *v1beta1.KafkaCluster) metav1.ObjectMeta {
44+
// ObjectMetaWithKafkaUserOwnerAndWithoutLabels returns a metav1.ObjectMeta object with ownerReference and name
45+
func ObjectMetaWithKafkaUserOwnerAndWithoutLabels(name string, user *v1alpha1.KafkaUser) metav1.ObjectMeta {
4546
return metav1.ObjectMeta{
4647
Name: name,
47-
Namespace: namespace,
48+
Namespace: user.GetNamespace(),
4849
OwnerReferences: []metav1.OwnerReference{
4950
{
50-
APIVersion: cluster.APIVersion,
51-
Kind: cluster.Kind,
52-
Name: cluster.Name,
53-
UID: cluster.UID,
51+
APIVersion: user.APIVersion,
52+
Kind: user.Kind,
53+
Name: user.Name,
54+
UID: user.UID,
5455
Controller: util.BoolPointer(true),
5556
BlockOwnerDeletion: util.BoolPointer(true),
5657
},

0 commit comments

Comments
 (0)