Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config validation by default #844

Open
shazron opened this issue Jan 28, 2025 · 1 comment
Open

add config validation by default #844

shazron opened this issue Jan 28, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@shazron
Copy link
Member

shazron commented Jan 28, 2025

Right now, config validation is not turned on by default and only certain commands turn it on, like the app pack command:

const appConfig = await libConfig.load({ validateAppConfig: true })

Modify BaseCommand.getFullConfig to validate the app config by default - this means that all commands that call getFullConfig will validate the config by default, even if they don't use the whole config:
https://github.com/search?q=repo%3Aadobe%2Faio-cli-plugin-app%20getFullConfig&type=code

BaseCommand.getFullConfig:

const validateAppConfig = options.validateAppConfig === true

Provide a shared flag in the BaseCommand to turn off config validation, just in case there are issues:

@shazron shazron added the enhancement New feature or request label Jan 28, 2025
@aiojbot
Copy link
Collaborator

aiojbot commented Jan 28, 2025

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants