Skip to content

Commit 3e4f4f7

Browse files
authored
feat: run add-vscode-config generator on app init (retooled local debugging) (#798)
1 parent e9d4bf8 commit 3e4f4f7

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@adobe/aio-lib-runtime": "^6",
1616
"@adobe/aio-lib-templates": "^3",
1717
"@adobe/aio-lib-web": "^7",
18-
"@adobe/generator-aio-app": "^7",
18+
"@adobe/generator-aio-app": "^8",
1919
"@adobe/generator-app-common-lib": "^2",
2020
"@adobe/inquirer-table-checkbox": "^2",
2121
"@oclif/core": "^2.11.6",

src/commands/app/init.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class InitCommand extends TemplatesCommand {
7575

7676
getInitialGenerators (flags) {
7777
// TODO read from config to override
78-
const initialGenerators = ['base-app', 'add-ci']
78+
const initialGenerators = ['base-app', 'add-ci', 'add-vscode-config']
7979

8080
if (flags['standalone-app']) {
8181
initialGenerators.push('application')

test/commands/app/init.test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ describe('--no-login', () => {
314314
await command.run()
315315

316316
expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
317-
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], false, 'cwd', 'basic')
317+
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], false, 'cwd', 'basic')
318318
expect(LibConsoleCLI.init).not.toHaveBeenCalled()
319319
expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
320320
})
@@ -464,7 +464,7 @@ describe('--no-login', () => {
464464
await command.run()
465465

466466
expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
467-
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], true, 'cwd', 'none')
467+
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], true, 'cwd', 'none')
468468
expect(LibConsoleCLI.init).not.toHaveBeenCalled()
469469
expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
470470
})
@@ -482,7 +482,7 @@ describe('--no-login', () => {
482482
await command.run()
483483

484484
expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
485-
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], true, 'cwd', 'adobe-recommended')
485+
expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], true, 'cwd', 'adobe-recommended')
486486
expect(LibConsoleCLI.init).not.toHaveBeenCalled()
487487
expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
488488
})

0 commit comments

Comments
 (0)