Mismatch for required and optional fields compared to defintions from main website

[troygNZ]

Firstly, a great effort in making this OSS and available.
Section 4.2.1 of https://www.icar.org/Guidelines/15-Procedure-4-Reproduction-Data.pdf specifies that heat detection method is mandatory for heat events. Looking at the JSON/OpenAPI specification for the heat events it does not make it required.

This means auto-generated clients on null-aware languages will not generate fully descriptive DTOs, and tools like SwaggerEditor don't document all finer details on what's required.

Secondarily: The list of enumerations also seems to have grown relative to the website. Should the website be updated, or reference this stuff directly?

[cookeac]

Thanks @troygNZ . Unfortunately the section 15 ADE guideline PDF files from the main ICAR web site are hopelessly out of date (they are 5-6 years old). The Animal Data Exchange working group has been asking ICAR to remove these for some time.

The correct location for the specifications is this GitHub repository, and the JSON Schema specifications are the definitive specification.

[troygNZ]

Thanks @cookeac, that clears that up

[cookeac]

Closing this in favour of #507