Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inview and onscreen events not triggered when element off screen #630

Open
danielghost opened this issue Feb 26, 2025 · 0 comments · May be fixed by #633
Open

inview and onscreen events not triggered when element off screen #630

danielghost opened this issue Feb 26, 2025 · 0 comments · May be fixed by #633
Assignees
@danielghost
Labels
bug

Comments

@danielghost
Copy link
Contributor

With the changes applied in https://github.com/adaptlearning/adapt-contrib-core/releases/tag/v6.55.0, it seems that the inview and onscreen events no longer trigger when an element moves off screen. This means listeners such as https://github.com/adaptlearning/adapt-contrib-media/blob/e8b08fa5d5fe45ba2d0f95aa4675b9764c8e7dfd/js/mediaView.js#L310-L312 won't pause playback when off screen.

This seems to be caused by the addition of returning early if !measurement.onscreen when the library was rewritten:

adapt-contrib-core/libraries/inview.js

Line 99 in 4f7615b

if (!hasMeasureChanged || !measurement.onscreen) return;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: trigger inview and onscreen events when element off screen adaptlearning/adapt-contrib-core
1 participant
@danielghost