Skip to content

Commit c556847

Browse files
authored
Fix: Resolve title/altTitle discrepancy (fixes #535)
1 parent 9c3ce16 commit c556847

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

js/models/questionModel.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -283,12 +283,13 @@ class QuestionModel extends ComponentModel {
283283
) || {};
284284
};
285285

286-
const altTitle = feedback.altTitle || Adapt.course.get('_globals')._accessibility.altFeedbackTitle;
287-
const title = feedback.title || this.get('title') || altTitle || '';
286+
const altFeedbackTitle = Adapt.course.get('_globals')._accessibility.altFeedbackTitle;
287+
const hasTitle = Boolean(feedback.title || this.get('title'));
288+
const isAltTitle = Boolean(feedback.altTitle) || (!hasTitle && altFeedbackTitle);
289+
const title = (feedback.altTitle || feedback.title || this.get('title') || altFeedbackTitle || '');
288290

289291
const feedbackConfig = {
290-
isAltTitle: (title === altTitle),
291-
altTitle,
292+
isAltTitle,
292293
title: Handlebars.compile(title)(this.toJSON()),
293294
_classes: feedback._classes,
294295
...(isLegacyConfig
@@ -307,7 +308,7 @@ class QuestionModel extends ComponentModel {
307308
// Used to setup the correct, incorrect and partly correct feedback
308309
setupFeedback() {
309310
if (!this.has('_feedback')) return;
310-
const { altTitle = '', title = '', body = '' } = this.getFeedback();
311+
const { title = '', body = '' } = this.getFeedback();
311312

312313
this.set({
313314
feedbackTitle: Handlebars.compile(title)(this.toJSON()),

0 commit comments

Comments
 (0)