add tests for ParameterIncompatibleWithMatchedType

Author: adamfk

src/Moq/MatcherFactory.cs

@@ -110,7 +110,7 @@ public static Pair<IMatcher, Expression> CreateMatcher(Expression argument, Para
 							matchedValuesType = convertExpression.Operand.Type;
 						}
 
-						if (!parameter.ParameterType.IsAssignableFrom(matchedValuesType))
+						if (ParameterIncompatibleWithMatchedType(parameterType: parameter.ParameterType, matchedValuesType))
 						{
 							throw new ArgumentException(
 								string.Format(
@@ -126,6 +126,11 @@ public static Pair<IMatcher, Expression> CreateMatcher(Expression argument, Para
 			return MatcherFactory.CreateMatcher(argument);
 		}
 
+		public static bool ParameterIncompatibleWithMatchedType(Type parameterType, Type matchType)
+		{
+			return !parameterType.IsAssignableFrom(matchType);
+		}
+
 		public static Pair<IMatcher, Expression> CreateMatcher(Expression expression)
 		{
 			// Type inference on the call might 

tests/Moq.Tests/Matchers/AnyMatcherFixture.cs

@@ -50,6 +50,32 @@ public void DoesntMatchIfNotAssignableType()
 			Assert.False(matcher.Matches("foo", typeof(IFormatProvider)));
 		}
 
+		[Fact]
+		public void ParameterIncompatibleWithMatchedType()
+		{
+			//shorthand wrapper
+			void AssertNotCompatible(Type parameterType, Type matchType)
+			{
+				Assert.True(MatcherFactory.ParameterIncompatibleWithMatchedType(parameterType: parameterType, matchType: matchType));
+			}
+			//shorthand wrapper
+			void AssertCompatible(Type parameterType, Type matchType)
+			{
+				Assert.False(MatcherFactory.ParameterIncompatibleWithMatchedType(parameterType: parameterType, matchType: matchType));
+			}
+
+			// incompatible tests
+			AssertNotCompatible(parameterType: typeof(DateTimeOffset), matchType: typeof(DateTime));
+			AssertNotCompatible(parameterType: typeof(DateTime), matchType: typeof(DateTimeOffset));
+			AssertNotCompatible(parameterType: typeof(DateTime), matchType: typeof(object));
+
+			// if mocked method parameter type is an object, should allow `It.IsAny<string>()`
+			AssertCompatible(parameterType: typeof(object), matchType: typeof(string));
+
+			// if mocked method parameter type is an object, should allow `It.IsAny<DateTime>()`
+			AssertCompatible(parameterType: typeof(object), matchType: typeof(DateTime));
+		}
+
 		private LambdaExpression ToExpression<TResult>(Expression<Func<TResult>> expr)
 		{
 			return expr;