Skip to content

Thumbnail popup in vertical mode #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Capital-Z opened this issue Oct 25, 2022 · 4 comments
Closed

Thumbnail popup in vertical mode #3

Capital-Z opened this issue Oct 25, 2022 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request released

Comments

@Capital-Z
Copy link

In vertical mode the thumbnail popup is covering other buttons. Since it is shown instantly it prevents from clicking on a desired app when the app button is under the pop-up.
It would be good to have some timeout, e.g. 1/3 of second, before the pop-up like the standard OS taskbar behaviour.
Also in vertical mode the thumbnail should be positioned on the right/left of the app button, not under/above. This can be done by dynamically changing the "Placement" property of the ThumbnailPopup.

@adamecr adamecr self-assigned this Oct 26, 2022
@adamecr adamecr added bug Something isn't working enhancement New feature or request labels Oct 26, 2022
@adamecr
Copy link
Owner

adamecr commented Oct 26, 2022

Hello Zhivko,
I didn't think about the popup placement in this case, as I don't "really" use the vertical mode. So it's a good catch, thanks. The fix should be simple and quick

It's also a good proposal with the delayed display of thumbnail. I have some idea how to do it, will give it a try and let's see.

I think i can patch it over the weekend

@adamecr adamecr added the finalizing To finish testing and documentation label Oct 26, 2022
@adamecr
Copy link
Owner

adamecr commented Oct 26, 2022

Both updates seems to be working, I'll use it for some time to test it and if there will be no hiccups, I'll relase the patch at the end of week

cc @Capital-Z

@adamecr adamecr added released and removed finalizing To finish testing and documentation labels Oct 28, 2022
@adamecr
Copy link
Owner

adamecr commented Oct 28, 2022

Released in Version 1.3.1

cc @Capital-Z

@Capital-Z
Copy link
Author

Both work fine for me now. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants