Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Treeshake #370

Merged
merged 9 commits into from
May 3, 2017
Merged

Treeshake #370

merged 9 commits into from
May 3, 2017

Conversation

TrySound
Copy link
Contributor

Tried to treeshake whatever possible. But shallowEqual still fails because of commonjs. Bad dependency.

@codecov-io
Copy link

codecov-io commented Apr 30, 2017

Codecov Report

Merging #370 into master will decrease coverage by 4.24%.
The diff coverage is 80.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   92.98%   88.73%   -4.25%     
==========================================
  Files          51       50       -1     
  Lines         328      373      +45     
==========================================
+ Hits          305      331      +26     
- Misses         23       42      +19
Impacted Files Coverage Δ
src/packages/recompose/setPropTypes.js 100% <ø> (ø) ⬆️
src/packages/recompose/setStatic.js 100% <ø> (ø) ⬆️
src/packages/recompose/setDisplayName.js 100% <ø> (ø) ⬆️
src/packages/recompose/renderNothing.js 100% <ø> (ø) ⬆️
src/packages/recompose/renderComponent.js 100% <ø> (ø) ⬆️
src/packages/recompose/__tests__/utils.js 100% <100%> (ø) ⬆️
src/packages/recompose/componentFromStream.js 100% <100%> (ø) ⬆️
src/packages/recompose/defaultProps.js 85.71% <100%> (-14.29%) ⬇️
src/packages/recompose/onlyUpdateForPropTypes.js 90% <100%> (-10%) ⬇️
src/packages/recompose/getContext.js 87.5% <100%> (-12.5%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e3baf...0b54774. Read the comment docs.

@istarkov
Copy link
Contributor

istarkov commented May 2, 2017

I see no issues, @wuct please merge if all is ok from your side.

@istarkov
Copy link
Contributor

istarkov commented May 2, 2017

We need to think about moving fbjs shallowEqual into the recompose, this will solve that shallowEqual is not tree shaked and included with every import.

@TrySound
Copy link
Contributor Author

TrySound commented May 2, 2017

Or better, introduce es modules in fbjs to make happy everybody.

@wuct
Copy link
Contributor

wuct commented May 2, 2017

Should we open a new issue for shouldComponentUpdate?

@TrySound
Copy link
Contributor Author

TrySound commented May 2, 2017

In react? Or you are about shouldUpdate hoc?

@wuct
Copy link
Contributor

wuct commented May 2, 2017

Oh, I mean recompose/shallowEqual. I am typing on my phone. sorry for the mistake.

@wuct
Copy link
Contributor

wuct commented May 2, 2017

I am going to merge this PR. Let's track shallowEqual in other issue.

@TrySound
Copy link
Contributor Author

TrySound commented May 2, 2017

ShallowEqual export is tree shaked. Fbjs/shallowEqual dep is not.

@TrySound
Copy link
Contributor Author

TrySound commented May 2, 2017

Okay

@wuct wuct merged commit e50934e into acdlite:master May 3, 2017
@wuct
Copy link
Contributor

wuct commented May 3, 2017

@TrySound Thanks for your great work!

@wuct wuct mentioned this pull request May 3, 2017
@TrySound TrySound deleted the treeshake branch May 3, 2017 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants