new React 15.5 broke build (fixed), lifecycle causes deprecation warnings (in review).

[istarkov]

Fixing now, seems like we have a problem with lifecycle method.

[istarkov]

The problem with current lifecycle that it uses React.createClass, and this https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.createclass will break support of react 14 users (I'm still using it ;-()

[istarkov]

Lifecycle #346

[MichaelDeBoey]

Any update on this one? :-)

[istarkov]

Yes, 11 days ago, see Releases

[istarkov]

I forgot to close issue after enzyme update ;-)

[MichaelDeBoey]

@istarkov I still get the following warnings (from the lifecycle method):
Warning: A Component: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Stacktrace:

printWarning	@	warning.js:36
warning		@	warning.js:60
createClass	@	ReactClass.js:628
(anonymous)	@	lifecycle.js:28
(anonymous)	@	createHelper.js:31

[TrySound]

@MichaelDeBoey Remove node_modules and run npm install

[MichaelDeBoey]

@TrySound I did this, but still get the warning

[TrySound]

@MichaelDeBoey Which version specified in package.json?

[MichaelDeBoey]

"recompose": "^0.21.0",

[istarkov]

https://github.com/acdlite/recompose/releases/tag/v0.23.0

Must be ^0.23.0

And even better to have last

[mistadikay]

@MichaelDeBoey try this amazing tool https://semver.npmjs.com/ it'll help you to understand how versioning in npm works 😬

[MichaelDeBoey]

Doh! 😓
Looked over that 😓 😕

[isSerge]

I still get this issue😒:
"react": "^15.5.4",
"recompose": "^0.23.4",

[istarkov]

What issue? Please be specific.

[isSerge]

Warnings from the lifecycle method:
Warning: getInitialState was defined on lifecycle(Component), a plain JavaScript class. This is only supported for classes created using React.createClass. Did you mean to define a state property instead?

[istarkov]

It's not "this issue" as you can see.

getInitialState now is not supported in lifecycle as React.createClass isn't used any more in recompose.

[isSerge]

Oh, I see, thanks