Skip to content

Commit f8e3b41

Browse files
committed
[#1970782] Escaping html entities for comment field during post and put operations
1 parent 9f628de commit f8e3b41

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

components/resc-backend/src/resc_backend/db/model/finding.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# pylint: disable=R0902
22
# Standard Library
3+
import html
34
from datetime import datetime
45

56
# Third Party
@@ -57,7 +58,7 @@ def create_from_finding(finding):
5758
commit_timestamp=finding.commit_timestamp,
5859
author=finding.author,
5960
status=finding.status,
60-
comment=finding.comment,
61+
comment=html.escape(finding.comment),
6162
event_sent_on=finding.event_sent_on,
6263
branch_id=finding.branch_id
6364
)

components/resc-backend/src/resc_backend/resc_web_service/crud/finding.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# pylint: disable=R0916,R0912
22
# Standard Library
3+
import html
34
import logging
45
from datetime import datetime
56
from typing import List
@@ -24,8 +25,7 @@
2425
def update_finding(db_connection: Session, finding_id: int, finding: finding_schema.FindingUpdate):
2526
db_finding = db_connection.query(model.DBfinding).filter_by(id_=finding_id).first()
2627
db_finding.status = finding.status
27-
db_finding.comment = finding.comment
28-
28+
db_finding.comment = html.escape(finding.comment)
2929
db_connection.commit()
3030
db_connection.refresh(db_finding)
3131
return db_finding
@@ -59,7 +59,7 @@ def audit_finding(db_connection: Session, db_finding: finding_schema.FindingRead
5959
The output will contain the findings that was updated
6060
"""
6161
db_finding.status = status
62-
db_finding.comment = comment
62+
db_finding.comment = html.escape(comment)
6363

6464
db_connection.commit()
6565
db_connection.refresh(db_finding)

0 commit comments

Comments
 (0)