Skip to content

Commit ded4b79

Browse files
committed
[2416709] Add css for repositories table rows clickable and unclickable based on scan_id value, fixed vcs scanner flow image in readme
1 parent becde9e commit ded4b79

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ The flow diagram below shows the different stages that a VCS Scanner Worker goes
9999
come to the desired result. It first picks up a repository from the queue where it is decided, in conjunction with user input, what type of scan to run.
100100
If it is a base scan, a full scan of all commits will be carried out to look for secrets. Possible findings are stored inside the database along with the last scanned commit hash of the repository. An incremental scan, where the repository was scanned earlier, only looks at the commits that were made after the last scanned commit hash. The process of finding secrets and storing them in the database is similar as previously described.
101101

102-
![product-screenshot!](images/RESC_Scan_Flow_Diagram.svg)
102+
![product-screenshot!](images/RESC_Scan_Flow_Diagram.png)
103103

104104
### RESC high-level overview
105105
The diagram below gives a high-level overview of the Repository Scanner tool. All the different components of the

components/resc-frontend/src/styles/main.css

+7-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
#rule-analysis-table th, #scan-findings-table th, #repositories-table th {
9696
cursor: pointer !important;
9797
}
98-
#rule-analysis-table tr, #scan-findings-table tr, #repositories-table tr, #rule-metrics-table tr {
98+
#rule-analysis-table tr, #scan-findings-table tr, #rule-metrics-table tr {
9999
cursor: pointer !important;
100100
}
101101
#rule-analysis-table .tabs, #scan-findings-table .tabs {
@@ -448,4 +448,10 @@
448448
.download-button{
449449
color: #3893e2;
450450
cursor: pointer;
451+
}
452+
.row-unclickable {
453+
cursor: not-allowed !important;
454+
}
455+
.row-clickable {
456+
cursor: pointer !important;
451457
}

components/resc-frontend/src/views/Repositories.vue

+4
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
responsive
3737
small
3838
head-variant="light"
39+
:tbody-tr-class="rowClass"
3940
@row-clicked="goToScanFindings"
4041
>
4142
<!-- Repository Column -->
@@ -156,6 +157,9 @@ export default {
156157
},
157158
},
158159
methods: {
160+
rowClass(item) {
161+
return item.last_scan_id ? 'row-clickable' : 'row-unclickable';
162+
},
159163
formatDate(timestamp) {
160164
const date = DateUtils.formatDate(timestamp);
161165
return timestamp ? date : 'Not Scanned';

0 commit comments

Comments
 (0)