Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BETTER_ENUMS_IGNORE_ATTRIBUTES_* for clang #81

Merged
merged 2 commits into from
Jan 13, 2020

Conversation

janten
Copy link
Contributor

@janten janten commented Jan 10, 2020

No description provided.

@janten
Copy link
Contributor Author

janten commented Jan 10, 2020

The build errors in Travis CI seem to be unrelated to the change here. Could you check this, @aantron?

@aantron
Copy link
Owner

aantron commented Jan 11, 2020

@janten Thanks. Yes, the Travis errors are unrelated, and we should ignore them :) I should probably disable Travis for now, as I don't have time to fix this the "right" way at the moment.

Can you say what error this PR addresses? These macros were added because a GCC version had broken handling of -Wattributes (#79). Is there a similar problem with some versions of Clang?

@janten
Copy link
Contributor Author

janten commented Jan 11, 2020

I am using Xcode 11.3 and was getting warnings about BETTER_ENUMS_IGNORE_ATTRIBUTES_BEGIN being undefined, which I fixed here. A previous version of Better Enums, which did not have BETTER_ENUMS_IGNORE_ATTRIBUTES_BEGIN at all, also worked fine.

@aantron
Copy link
Owner

aantron commented Jan 11, 2020

Thanks. I think these macros should be defined to expand to nothing on Clang. Can you try that?

@janten
Copy link
Contributor Author

janten commented Jan 13, 2020

It works with empty #defines, too. I updated the source accordingly.

@aantron aantron merged commit dcbd3c0 into aantron:master Jan 13, 2020
@aantron
Copy link
Owner

aantron commented Jan 13, 2020

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants