Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting image pull policy for job image #124

Closed
AdrianoKF opened this issue Oct 8, 2024 · 0 comments · Fixed by #132
Closed

Allow setting image pull policy for job image #124

AdrianoKF opened this issue Oct 8, 2024 · 0 comments · Fixed by #132
Assignees
Labels
backend Related to the backend / server component. enhancement New feature or request

Comments

@AdrianoKF
Copy link
Collaborator

AdrianoKF commented Oct 8, 2024

Currently, all containerized workloads have their image pull policy set to IfNotPresent.

This change was originally made to facilitate the e2e testing setup (where the image cannot be pulled due to a lack of a registry).

However, this default comes with a huge downside: repeatedly re-submitting a workload won't work (meaning, the old image will be re-used), unless the node image cache is cleaned manually (which first requires removing any stopped containers using the old workload image).

A more sensible solution would be to expose this image pull policy as part of the job submission options so that users can choose for themselves.
IMO, Always would be the safest default to prevent any surprises due to outdated images being reused.

@AdrianoKF AdrianoKF added enhancement New feature or request backend Related to the backend / server component. labels Oct 8, 2024
@maxmynter maxmynter self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend / server component. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants