Skip to content

Commit 541d66b

Browse files
committed
Add release binaries for Windows and Linux!
1 parent 38abdf6 commit 541d66b

File tree

3 files changed

+34
-11
lines changed

3 files changed

+34
-11
lines changed

README.md

+21-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ load("@aabtop_rules_qt//:rules_qt_deps2.bzl", "rules_qt_deps2")
2121
rules_qt_deps2()
2222
```
2323

24-
to your `WORKSPACE` file.
24+
to your `WORKSPACE` file. Note that by default, it will reference pre-built
25+
Qt binaries stored as a GitHub release for this repository. If you would like
26+
to build Qt from source, modify the last line above from `rules_qt_deps2()` to
27+
`rules_qt_deps2("local")`, and be prepared to wait a couple of hours.
28+
2529

2630
The rules can be accessed by loading:
2731

@@ -30,3 +34,19 @@ load("@aabtop_rules_qt//:qt_rules.bzl", "qt_cc_library", "qt_cc_binary", "qt_res
3034
```
3135

3236
See the [//sample/BUILD](sample/BUILD) file for example usage.
37+
38+
39+
## Rebuilding the binary releases
40+
41+
In order to rebuild the binary versions of Qt referenced in the releases,
42+
run `./build.sh out` on Linux and `./build.bat out`
43+
on Windows. Note that both of those commands require Docker (or Docker Desktop
44+
for Windows, in Windows mode) to be installed. You will then find the output
45+
archive in the `out/` folder, which can then be manually uploaded to GitHub as a
46+
release. Afterwards, the references to `aabtop_qt_bin_linux` and
47+
`aabtop_qt_bin_windows` should be updated in
48+
[rules_qt_deps1.bzl](rules_qt_deps1.bzl).
49+
50+
Finally, after the change above to update the releases is merged, the
51+
instructions in this README file above should be updated to point to the
52+
new commit hash which references the updated release archives.

rules_qt_deps1.bzl

+13
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,16 @@ def rules_qt_deps1():
1818
commit = "ebfb9377f616cf12ffe0a9e1088ca0c005bd2db4",
1919
shallow_since = "1611480038 +0000",
2020
)
21+
22+
http_archive(
23+
name="aabtop_qt_bin_linux",
24+
strip_prefix = "aabtop_qt_build",
25+
url = "https://github.com/aabtop/rules_qt/releases/download/v0.0.1/qt_linux.tar.gz",
26+
sha256 = "0b642145a6d991beb7a4e649aa691e07e4a70d8e83704def442a105930349c80",
27+
)
28+
29+
http_archive(
30+
name="aabtop_qt_bin_windows",
31+
url = "https://github.com/aabtop/rules_qt/releases/download/v0.0.1/qt_windows.zip",
32+
sha256 = "f153140e57b2a68db0aeb09d14a3087a942eb8ed2cf5ebd0126b30ace2b0a3e0",
33+
)

rules_qt_deps2.bzl

-10
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,6 @@ def rules_qt_deps2(local_build="prebuilt"):
1111

1212
fetch_and_build_qt(name="aabtop_qt_build")
1313

14-
native.local_repository(
15-
name="aabtop_qt_bin_windows",
16-
path="C:/Users/Andrew/foo/qt_windows_bin",
17-
)
18-
19-
native.local_repository(
20-
name="aabtop_qt_bin_linux",
21-
path="/mnt/c/Users/Andrew/foo/aabtop_qt_build"
22-
)
23-
2414
qt_bin(
2515
name="aabtop_qt_bin",
2616
local_build=local_build,

0 commit comments

Comments
 (0)