Make hasOwnProperty actually check

changlinli · changlinli · commit d906770e38fc · 2023-12-19T14:28:19.000-08:00
This is for added security
diff --git a/compiler/src/Generate/JavaScript/Expression.hs b/compiler/src/Generate/JavaScript/Expression.hs
@@ -739,7 +739,7 @@ generateTailDef mode name argNames body =
         (
           JS.Infix
             JS.OpAnd
-            (JS.Access (JS.Ref loopReturnName) JsName.hasOwnProperty) (JS.Infix JS.OpEq (JS.Access (JS.Ref loopReturnName) (JsName.fromLocal name)) (JS.Bool True))
+            (JS.Call (JS.Access (JS.Ref loopReturnName) JsName.hasOwnProperty) [JS.String (JsName.toBuilder $ JsName.fromLocal name)]) (JS.Infix JS.OpEq (JS.Access (JS.Ref loopReturnName) (JsName.fromLocal name)) (JS.Bool True))
         )
     loopBodyA = JS.Block
       [ JS.Var loopReturnName (JS.Call (JS.Ref loopAsFunctionName) [])

Original file line number	Diff line number	Diff line change
`@@ -739,7 +739,7 @@ generateTailDef mode name argNames body =`
`739`	`739`	`(`
`740`	`740`	`JS.Infix`
`741`	`741`	`JS.OpAnd`
`742`		`- (JS.Access (JS.Ref loopReturnName) JsName.hasOwnProperty) (JS.Infix JS.OpEq (JS.Access (JS.Ref loopReturnName) (JsName.fromLocal name)) (JS.Bool True))`
	`742`	`+ (JS.Call (JS.Access (JS.Ref loopReturnName) JsName.hasOwnProperty) [JS.String (JsName.toBuilder $ JsName.fromLocal name)]) (JS.Infix JS.OpEq (JS.Access (JS.Ref loopReturnName) (JsName.fromLocal name)) (JS.Bool True))`
`743`	`743`	`)`
`744`	`744`	`loopBodyA = JS.Block`
`745`	`745`	`[ JS.Var loopReturnName (JS.Call (JS.Ref loopAsFunctionName) [])`