Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if iterators have the same length in multiscalar multiplication #461

Closed
Tracked by #451
conradoplg opened this issue Jul 26, 2023 · 0 comments · Fixed by #494
Closed
Tracked by #451

Check if iterators have the same length in multiscalar multiplication #461

conradoplg opened this issue Jul 26, 2023 · 0 comments · Fixed by #494
Assignees
@dconnolly
Milestone
FROST Audit

Comments

@conradoplg
Copy link
Contributor

We are not checking if the list of scalars and elements have the same size. See audit report for details.

Fix that and return an error if they don't match.
@dconnolly dconnolly self-assigned this Jul 26, 2023
@mpguerra mpguerra mentioned this issue Jul 27, 2023
Closed
26 tasks
@conradoplg conradoplg mentioned this issue Aug 21, 2023
Merged
@mpguerra mpguerra added this to the FROST Audit milestone Aug 24, 2023
@mpguerra mpguerra added this to FROST Aug 24, 2023
@mpguerra mpguerra moved this to Review/QA in FROST Aug 24, 2023
@mergify mergify bot closed this as completed in #494 Aug 28, 2023
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
None yet
Projects
FROST
Archived in project
Milestone
FROST Audit
Development

Successfully merging a pull request may close this issue.

check if iterators have the same size in multiscalar mul ZcashFoundation/frost
3 participants
@conradoplg @dconnolly @mpguerra