Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use console.php for entering/exiting maintenance mode. #112

Merged
merged 4 commits into from
Feb 10, 2024

Conversation

orhtej2
Copy link
Contributor

@orhtej2 orhtej2 commented Sep 11, 2023

Problem

Solution

  • bin/console is a shell script, bin/console.php is a thing that needs to be run with PHP interpreter.
  • if backup fails maintenance mode is not disabled - use trap to deal with it.

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 11, 2023

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 11, 2023

!testme

@yunohost-bot
Copy link
Contributor

Meow 🐈
Test Badge

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 11, 2023

Seems to be working fine https://paste.yunohost.org/raw/hafepevile

@orhtej2 orhtej2 marked this pull request as ready for review September 11, 2023 20:35
@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 12, 2023

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 12, 2023

Seems to be working fine https://paste.yunohost.org/raw/hafepevile

It was backing up OK but restoring in maintenance mode hence restore test was failing.

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 12, 2023

(╯°□°)╯︵ ┻━┻

@orhtej2
Copy link
Contributor Author

orhtej2 commented Sep 12, 2023

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@orhtej2 orhtej2 changed the title DRAFT: Use console.php for entering/exiting maintenance mode. Use console.php for entering/exiting maintenance mode. Sep 12, 2023
@ericgaspar ericgaspar merged commit fe4078a into YunoHost-Apps:testing Feb 10, 2024
@orhtej2 orhtej2 deleted the patch-1 branch February 10, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants