Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Lock YUI dependency to version 3.6.x #2

Closed
wants to merge 1 commit into from

Conversation

mridgway
Copy link
Collaborator

Arrow does not seem to work with YUI 3.5 ("YUITest is not defined" in yuitest-runner.js) so it should be locked down to the 3.6 versions.

@proverma
Copy link

I am not sure if its just YUI 3.5 or something else, I am still working on that error, but we inject the npm YUI object only when YUI object is not found on that page, However the error you mentioned happens mostly on pages which already had some version of YUI. Hence I dont think version locking would have much impact on it....Also Doesn't "*" always gets the latest YUI version ( currently v3.6.0 ) ?

Thoughts ?

@mridgway
Copy link
Collaborator Author

I think you're right. When I first encountered this it was when I was using Arrow as a dependency from Mojito. Mojito already had YUI 3.5.1 as a dependency, so Arrow did not re-install YUI and thus used 3.5 instead of 3.6. Since then, I haven't actually run into this error though and Travis didn't either.

Closing since I can't reproduce it consistently anymore.

@mridgway mridgway closed this Aug 27, 2012
@mridgway
Copy link
Collaborator Author

mridgway commented Sep 5, 2012

Reopening based on issue #10.

@mridgway mridgway reopened this Sep 5, 2012
@travisbot
Copy link

This pull request passes (merged 1f4efc3 into 23b70ba).

@mridgway mridgway closed this Sep 12, 2012
proverma pushed a commit that referenced this pull request Mar 8, 2013
add config for recursive scan
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants