Skip to content

Commit 18f9c50

Browse files
committed
fix: Mocha version comparison fix
see stanleyhlng/mocha-multi-reporters#110
1 parent 786ece7 commit 18f9c50

File tree

3 files changed

+274
-202
lines changed

3 files changed

+274
-202
lines changed

cypress-multi-reporters/lib/MultiReporters.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ const util = require('util');
1313
const mocha = require('mocha');
1414
const {Base} = mocha.reporters;
1515
const path = require('path');
16+
const semver = require('semver');
1617

1718
let createStatsCollector;
1819
let mocha6plus;
@@ -23,7 +24,7 @@ try {
2324
);
2425
const {version} = json;
2526
// istanbul ignore else
26-
if (version >= '6') {
27+
if (semver.gte(version, '6.0.0')) {
2728
createStatsCollector = require('mocha/lib/stats-collector');
2829
mocha6plus = true;
2930
}

cypress-multi-reporters/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
"license": "MIT",
3535
"dependencies": {
3636
"debug": "^4.3.7",
37-
"lodash": "^4.17.21"
37+
"lodash": "^4.17.21",
38+
"semver": "^7.5.4"
3839
},
3940
"devDependencies": {
4041
"@commitlint/cli": "19.5.0",
@@ -44,7 +45,7 @@
4445
"eslint": "9.13.0",
4546
"eslint-config-defaults": "9.0.0",
4647
"husky": "9.1.6",
47-
"mocha": "8.4.0",
48+
"mocha": "11.1.0",
4849
"mocha-lcov-reporter": "1.3.0",
4950
"nyc": "17.1.0",
5051
"sinon": "19.0.2",

0 commit comments

Comments
 (0)