-
Notifications
You must be signed in to change notification settings - Fork 275
Modified algorithm for heat flow calculation #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please check the thermal_diffusion branch, where more general thermal dynamics equations are solved. |
@DrChiZhang could you make a pull request if you think the changes are done? |
Sure, I will try to merge master to this branch first. |
Heat flow is variable now in master branch: SPHinXsys/src/shared/shared_ck/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics_ck.h Line 156 in b655b1c
|
Describe the bug
The right hand side of diffusion_dt_ algorithm in all of diffusion types (Inner, Robin, etc. ) only calculate the rate of heat flow per unit volume (W/m3), we need to multiply a particle volume term to get heat flow (W), then we can use it for heat flux calculation.
Trace to the source
Steps to trace the source:
Modified algorithm
The modified diffusion_dt_m should be:
diffusion_dt_m = diffusion_dt_ * particle_volume
Additional context
However, this bug does not effect the final temperature field calculation, it is only useful if we want to calculate overall heat flow instead of volumetric heat flow.
The text was updated successfully, but these errors were encountered: