Skip to content

Commit 19cc1ee

Browse files
authored
fix node-addaon-api for vad (k2-fsa#932)
1 parent 99b65aa commit 19cc1ee

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/scripts/node-addon/run.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ fi
1818
SHERPA_ONNX_VERSION=$(grep "SHERPA_ONNX_VERSION" ./CMakeLists.txt | cut -d " " -f 2 | cut -d '"' -f 2)
1919
echo "SHERPA_ONNX_VERSION $SHERPA_ONNX_VERSION"
2020

21-
# SHERPA_ONNX_VERSION=1.0.27
21+
# SHERPA_ONNX_VERSION=1.0.28
2222

2323
if [ -z $owner ]; then
2424
owner=k2-fsa

.github/workflows/npm-addon.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
5656
SHERPA_ONNX_VERSION=$(grep "SHERPA_ONNX_VERSION" ./CMakeLists.txt | cut -d " " -f 2 | cut -d '"' -f 2)
5757
echo "SHERPA_ONNX_VERSION $SHERPA_ONNX_VERSION"
58-
# SHERPA_ONNX_VERSION=1.0.27
58+
# SHERPA_ONNX_VERSION=1.0.28
5959
6060
src_dir=.github/scripts/node-addon
6161
sed -i.bak s/SHERPA_ONNX_VERSION/$SHERPA_ONNX_VERSION/g $src_dir/package.json

scripts/node-addon-api/src/vad.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ static Napi::Float32Array CircularBufferGetWrapper(
137137
return float32Array;
138138
} else {
139139
// don't use external buffer
140-
Napi::ArrayBuffer arrayBuffer = Napi::ArrayBuffer::New(
141-
env, const_cast<float *>(data), sizeof(float) * n);
140+
Napi::ArrayBuffer arrayBuffer =
141+
Napi::ArrayBuffer::New(env, sizeof(float) * n);
142142

143143
Napi::Float32Array float32Array =
144144
Napi::Float32Array::New(env, n, arrayBuffer, 0);

scripts/node-addon-api/src/wave-writer.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ static Napi::Boolean WriteWaveWrapper(const Napi::CallbackInfo &info) {
1313

1414
if (info.Length() != 2) {
1515
std::ostringstream os;
16-
os << "Expect only 2 argument2. Given: " << info.Length();
16+
os << "Expect only 2 arguments. Given: " << info.Length();
1717

1818
Napi::TypeError::New(env, os.str()).ThrowAsJavaScriptException();
1919

0 commit comments

Comments
 (0)