You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As detailed in this comment, there are two issues with the codec of MPTAmount.
Non-str inputs are not handled correctly in the serialization of MPTAmount.value .
In the str type inputs, scientific notation is not handled.
It remains to be seen if IOU and XRP currencies correctly handle the above two issues. Appropriate unit tests need to written to that effect.
This PR reduces the API interface of the MPTAmount class to str type inputs only. It provides helpful type-hints and error-message to the users until such time as points-1 and 2 are addressed.
The text was updated successfully, but these errors were encountered:
As detailed in this comment, there are two issues with the codec of
MPTAmount
.str
inputs are not handled correctly in the serialization ofMPTAmount.value
.str
type inputs, scientific notation is not handled.This PR reduces the API interface of the
MPTAmount
class tostr
type inputs only. It provides helpful type-hints and error-message to the users until such time as points-1 and 2 are addressed.The text was updated successfully, but these errors were encountered: