Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in Codec of MPTAmount #816

Open
ckeshava opened this issue Mar 6, 2025 · 0 comments
Open

Errors in Codec of MPTAmount #816

ckeshava opened this issue Mar 6, 2025 · 0 comments

Comments

@ckeshava
Copy link
Collaborator

ckeshava commented Mar 6, 2025

As detailed in this comment, there are two issues with the codec of MPTAmount.

  1. Non-str inputs are not handled correctly in the serialization of MPTAmount.value .
  2. In the str type inputs, scientific notation is not handled.
  3. It remains to be seen if IOU and XRP currencies correctly handle the above two issues. Appropriate unit tests need to written to that effect.

This PR reduces the API interface of the MPTAmount class to str type inputs only. It provides helpful type-hints and error-message to the users until such time as points-1 and 2 are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant