Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build #4366

Closed
0x34d opened this issue Dec 8, 2022 · 4 comments
Closed

The build #4366

0x34d opened this issue Dec 8, 2022 · 4 comments
Labels
Feature Request Used to indicate requests to add new features

Comments

@0x34d
Copy link

0x34d commented Dec 8, 2022

In Nudb.cmake what is the meaning of NuDB not needed in the case of xrpl_core inclusion build.

How can I Disable NuDB while building?

@0x34d 0x34d added the Feature Request Used to indicate requests to add new features label Dec 8, 2022
@ximinez
Copy link
Collaborator

ximinez commented Dec 8, 2022

For reference, the line is https://github.com/XRPLF/rippled/blob/develop/Builds/CMake/deps/Nudb.cmake#L9

It is intended to prevent unnecessary builds of NuDB in configurations where rippled is used as a dependency to another project. An example is in https://github.com/ripple/validator-keys-tool/blob/master/CMakeLists.txt#L21-L66

There is currently no way to disable building NuDB when building rippled without changing code.

@0x34d
Copy link
Author

0x34d commented Dec 9, 2022

snappy,soci,rocksdb, are not working, If I build them outside ripple.
Somehow grpc work if I compile as link

My Gole is to compile all dep outside of the project and install them with make install and then use them in ripple project.

One last question.
Any future plan to support one proper platform and use default package provided by package manager, So building of Ripple won't be that much horrible.

@0x34d 0x34d changed the title Disable nudb. The build Dec 9, 2022
@legleux
Copy link
Collaborator

legleux commented Dec 9, 2022

The closest to your last question will be provided by using Conan to provide dependencies #4223

@0x34d 0x34d closed this as completed Dec 10, 2022
@0x34d
Copy link
Author

0x34d commented Dec 10, 2022

Appreciated your response.

Can you elaborate on patch , what is this?

If I'm not wrong then:
cmake -P ~/rippled/Builds/CMake/soci_patch.cmake
execute this command in soci root dir.

And Ripple Findsoci.cmake is not working with library.

/usr/local/lib/libsoci_empty.a
/usr/local/lib/libsoci_sqlite3.a
/usr/local/lib/libsoci_core.a

cmake :

cmake \
-DSOCI_INCLUDE_DIR=/usr/local/include/ \
-Dsoci=/usr/local/lib/libsoci_empty.a,/usr/local/lib/libsoci_sqlite3.a,/usr/local/lib/libsoci_core.a ../.

to Build soic

git checkout 04e1870294918d20761736743bb6136314c42dd5
cmake -P /root/rippled/Builds/CMake/soci_patch.cmake
mkdir my_build && cd my_build/
cmake \
    -DSOCI_CXX_C11=ON -DSOCI_STATIC=ON -DSOCI_LIBDIR=lib -DSOCI_SHARED=OFF -DSOCI_TESTS=OFF \
    -DBoost_INCLUDE_DIRS=/root/boost_1_75_0/ \
    -DWITH_BOOST=ON -DBoost_FOUND=ON -DBoost_DATE_TIME_FOUND=ON -DSOCI_HAVE_BOOST=ON \
    -DSOCI_HAVE_BOOST_DATE_TIME=ON -DBoost_DATE_TIME_LIBRARY=/root/boost_1_75_0/stage/lib/libboost_date_time.a \
    -DSOCI_SQLITE3=ON -DSQLITE3_INCLUDE_DIR=/usr/local/include/ -DSQLITE3_LIBRARY=/usr/local/lib/libsqlite3.a \
    ../.
make -j$(nproc) && make install

Also -Dlocal_rocksdb=OFF is not wotking.

@0x34d 0x34d reopened this Dec 10, 2022
@0x34d 0x34d closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Development

No branches or pull requests

3 participants