Pass Journal by value and make it last arg

Author: gregtatcam

src/ripple/overlay/Slot.h

@@ -112,7 +112,7 @@ class Slot final
      * @param journal Journal for logging
      * @param handler Squelch/Unsquelch implementation
      */
-    Slot(beast::Journal&& journal, SquelchHandler const& handler)
+    Slot(SquelchHandler const& handler, beast::Journal journal)
         : reachedThreshold_(0)
         , lastSelected_(clock_type::now())
         , state_(SlotState::Counting)
@@ -686,7 +686,7 @@ Slots<clock_type>::updateSlotAndSquelch(
         JLOG(journal_.debug())
             << "updateSlotAndSquelch: new slot " << Slice(validator);
         auto [it, _] = slots_.emplace(std::make_pair(
-            validator, Slot<clock_type>(app_.journal("Slot"), handler_)));
+            validator, Slot<clock_type>(handler_, app_.journal("Slot"))));
         it->second.update(validator, id, type);
     }
     else