From 194ed2b0899daf346c44b822038886f0df3862ca Mon Sep 17 00:00:00 2001 From: Sarah Norris Date: Thu, 22 Jun 2023 11:57:26 +0100 Subject: [PATCH 1/3] Use focus-visible rather than focus on ItemGroup buttons --- packages/components/src/item-group/styles.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/item-group/styles.ts b/packages/components/src/item-group/styles.ts index 07ef6ba28db6e..670fdf987dd93 100644 --- a/packages/components/src/item-group/styles.ts +++ b/packages/components/src/item-group/styles.ts @@ -24,7 +24,7 @@ export const unstyledButton = css` color: ${ COLORS.ui.theme }; } - &:focus { + &:focus-visible { box-shadow: 0 0 0 var( --wp-admin-border-width-focus ) var( --wp-components-color-accent, From 7324bb271323c8d4564740984a50c2d0201ecd63 Mon Sep 17 00:00:00 2001 From: Sarah Norris Date: Thu, 22 Jun 2023 12:02:00 +0100 Subject: [PATCH 2/3] Update snapshot --- .../preferences-modal/test/__snapshots__/index.js.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap b/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap index a962cfbe81919..182531ee01c02 100644 --- a/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap +++ b/packages/edit-post/src/components/preferences-modal/test/__snapshots__/index.js.snap @@ -616,7 +616,7 @@ exports[`EditPostPreferencesModal should match snapshot when the modal is active color: var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9)); } -.emotion-13:focus { +.emotion-13:focus-visible { box-shadow: 0 0 0 var( --wp-admin-border-width-focus ) var( --wp-components-color-accent, var( --wp-admin-theme-color, var(--wp-components-color-accent, var(--wp-admin-theme-color, #3858e9)) ) From bb9332fd4bbf19ba14efe314d787cd5f42370142 Mon Sep 17 00:00:00 2001 From: Sarah Norris Date: Thu, 22 Jun 2023 12:10:44 +0100 Subject: [PATCH 3/3] Update Changelog --- packages/components/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 2759cc629a336..d43112718f91e 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -7,6 +7,7 @@ - `UnitControl`: Revamp support for changing unit by typing ([#39303](https://github.com/WordPress/gutenberg/pull/39303)). - `Modal`: Update corner radius to be between buttons and the site view frame, in a 2-4-8 system. ([#51254](https://github.com/WordPress/gutenberg/pull/51254)). - `ItemGroup`: Update button focus state styles to be inline with other button focus states in the editor. ([#51576](https://github.com/WordPress/gutenberg/pull/51576)). +- `ItemGroup`: Update button focus state styles to target `:focus-visible` rather than `:focus`. ([#51787](https://github.com/WordPress/gutenberg/pull/51787)). ### Bug Fix