Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter {post_gallery} does not work with Gutenberg #9001

Closed
Oxibug opened this issue Aug 15, 2018 · 2 comments
Closed

Filter {post_gallery} does not work with Gutenberg #9001

Oxibug opened this issue Aug 15, 2018 · 2 comments
Labels
[Type] Help Request Help with setup, implementation, or "How do I?" questions.

Comments

@Oxibug
Copy link

Oxibug commented Aug 15, 2018

Describe the bug
Hi Guys,

I'm using the {post_gallery} filter to styling the post content galleries BUT after activating Gutenberg you force my theme to use your style, I try to turn the filter's priority to 99 but the plugin restyled everything inside the content.

So I think you should make a new filter to help developers to make their own styles.

Thanks for your GREAT project.

To Reproduce
Using WordPress filter {post_gallery}
add_filter( 'post_gallery', array( &$this, 'styling_post_gallery' ), 10, 3 );

Expected behavior
Use masonry galleries

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: 68

Additional context
Gutenberg v3.5.0

@designsimply designsimply added the [Type] Help Request Help with setup, implementation, or "How do I?" questions. label Aug 15, 2018
@mcsf
Copy link
Contributor

mcsf commented Aug 23, 2018

Hi there.

It's important to note that native Galleries in Gutenberg are blocks and not shortcodes. In your scenario, are you using Gallery blocks, or the [gallery] shortcode?

In any case, I suggest reading Extensibility > Theme Support, but I'd like to know more details in order to help you.

@mtias mtias closed this as completed Aug 24, 2018
@Oxibug
Copy link
Author

Oxibug commented Aug 25, 2018

Yes pal, I know that I'm using the WordPress shortcode, But if the WordPress decide to use the Gutenberg in version 5.0 Then all websites using galleries will be corrupted and you'll force all websites to use your style.

So We (Developers) must update all themes to style your new gallery and (if we did) we cannot force your gallery to use Justified-Gallery (for example) instead, so You'll force us to just style the gallery images css only and this is very bad for any blog theme and bloggers, As well as the filter (post_gallery) will be no longer important for anyone.

Thanks for your great project.

Good Luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Help Request Help with setup, implementation, or "How do I?" questions.
Projects
None yet
Development

No branches or pull requests

4 participants