-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Revisions: solid border matching background around the preview for revisions #57601
Comments
Hi @annezazu! Thanks for the ping. Do you mean the red/white border? I spun up clean WP instance with TT3, added some revisions, and couldn't reproduce (Gutenberg 17.4.1). 🤔 Also checked with TT4 and TT2. 2024-01-06.09.07.07.mp4Is it possible that there's a border style on the body in your setup? If you have time, could you reset the global styles and save a few revisions to check? Thank you! |
I retested and couldn't replicate. I also checked the editor container styles and there are no border declarations. The "Whisper" style variation on TT3 does have a body border style built in, but I can't see that the editor is adding any extra border styles. I'll close for now. Please reopen and assign to me if the problem persists. 🙇🏻 |
Yes! I am talking about the border around the zoomed out view. I can still replicate from the site I took the video from using WP 6.4.2, GB 17.4.1, and TT3. Happy to add you to the site. We've used it for demos in the past ahead of releases. |
Thanks! Yes please. It'd be great to see the test site. I'll report back here. |
🤦🏻 Firstly, sorry for closing this prematurely, and missing the complete obvious. I've been able to replicate thanks to @annezazu 🙇🏻 PR here: |
Thanks so much for tracking this down! |
And to you for pointing me in the right direction 🚀 |
Excitedly testing out the new ability to use the Style Book with revisions when I noticed a border exists around the revision preview. This doesn't match with what I could see in the video of the PR that implemented this new feature. cc @ramonjd
Screen.Recording.2024-01-05.at.10.47.04.AM.mov
This is using 6.4.2, GB 17.4.1, and TT3 theme.
The text was updated successfully, but these errors were encountered: