-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling blocks: Color panel descriptions are ambiguous #47026
Comments
A couple of options: Contextual descriptions:
Less explicit descriptions
Add context to the panel UIThe current descriptions might not be so ambiguous if there was something to indicate what it is you're styling: cc @WordPress/gutenberg-design |
It's not in scope, but we could use a better panel navigation — breadcrumbs style perhaps — which would add the context needed to know where you're at, and what you're doing. Like |
Do you think just saying I wasn't thinking we'd need "default", but we probably do - as this change won't affect any button block with modified background/text attributes. |
Breadcrumbs aren't perfect, but I agree something like that could help with orientation. @SaxonF has shared such concepts before.
Good point, we also need to consider style variations. IE:
So now the description has to include the block name, and the chosen style variation where applicable. Is the additional logic worthwhile, or would a generic description ("Set a background color") be better? More radical: Do we actually need a description in this context? Doesn't the navigational path make it obvious what you're doing? |
That's a very good question. It would probably solve a lot of issues (including this one) if they were the same. |
No longer an issue :) |
Navigate to: Styles > Blocks > Button > Colors > Background and you see the following UI:
From the description, you might interpret the change to affect the whole site rather than just the Button block.
The Text panel is similar:
This feels a bit buggy, and could do with some attention.
The text was updated successfully, but these errors were encountered: