Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling blocks: Color panel descriptions are ambiguous #47026

Closed
jameskoster opened this issue Jan 10, 2023 · 7 comments
Closed

Styling blocks: Color panel descriptions are ambiguous #47026

jameskoster opened this issue Jan 10, 2023 · 7 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

Navigate to: Styles > Blocks > Button > Colors > Background and you see the following UI:

Screenshot 2023-01-10 at 11 56 44

From the description, you might interpret the change to affect the whole site rather than just the Button block.

The Text panel is similar:

Screenshot 2023-01-10 at 11 59 01

This feels a bit buggy, and could do with some attention.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jan 10, 2023
@jameskoster
Copy link
Contributor Author

A couple of options:

Contextual descriptions:

Set a background color or gradient for Buttons.

Set the default color used for Button text across the site

Less explicit descriptions

Set a background color or gradient

Set the text color

Add context to the panel UI

The current descriptions might not be so ambiguous if there was something to indicate what it is you're styling:

Screenshot 2023-01-10 at 12 06 03

cc @WordPress/gutenberg-design

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. labels Jan 10, 2023
@richtabor
Copy link
Member

It's not in scope, but we could use a better panel navigation — breadcrumbs style perhaps — which would add the context needed to know where you're at, and what you're doing.

Like Styles > Button > Text or such.

@richtabor
Copy link
Member

Set a background color or gradient for Buttons.

Do you think just saying Set the default background for Button blocks is clear enough?

I wasn't thinking we'd need "default", but we probably do - as this change won't affect any button block with modified background/text attributes.

@jameskoster
Copy link
Contributor Author

jameskoster commented Jan 12, 2023

Breadcrumbs aren't perfect, but I agree something like that could help with orientation. @SaxonF has shared such concepts before.

I wasn't thinking we'd need "default", but we probably do - as this change won't affect any button block with modified background/text attributes.

Good point, we also need to consider style variations. IE:

Set the default background for Outline Button blocks

So now the description has to include the block name, and the chosen style variation where applicable. Is the additional logic worthwhile, or would a generic description ("Set a background color") be better? More radical: Do we actually need a description in this context? Doesn't the navigational path make it obvious what you're doing?

@SaxonF
Copy link
Contributor

SaxonF commented Jan 16, 2023

Worth exploring what a breadcrumb approach might look like. From previous explorations:

image

Difficulty will be when working with longer block names.

Related question, why does the global block panel differ from the local block panel?

image

@jameskoster
Copy link
Contributor Author

Related question, why does the global block panel differ from the local block panel?

That's a very good question. It would probably solve a lot of issues (including this one) if they were the same.

@jameskoster
Copy link
Contributor Author

No longer an issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants