Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: set border-color as a variable instead of hex code in Code Block #42995

Closed
ghost opened this issue Aug 4, 2022 · 3 comments
Closed
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Enhancement A suggestion for improvement.

Comments

@ghost
Copy link

ghost commented Aug 4, 2022

What problem does this address?

Similar to: #36462

In WordPress 6.0.1, when you choose one of the colors from the color palette to set it as the border-color of the Code Block,

  1. in the Editor, the border-color is set as a variable in the Code Block. ✔️

image

  1. in Global Styles, the border-color is set as a hex color in the Code Block. ❌

image

What is your proposed solution?

Border-color coming from Global Styles to be set as a CSS variable in the Code Block.

Why?
Allows full site editing to change border-colors without needing to individually change every instance of the Code Block to update to the new border-color.

Please confirm that you have searched existing issues in the repo.

Yes

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. CSS Styling Related to editor and front end styles, CSS-specific issues. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Mar 3, 2023
@glendaviesnz
Copy link
Contributor

If you add a custom color to your palette in global styles and use this to set the border color this will be applied as a variable:

Screenshot 2023-04-13 at 11 27 06 AM

Going to close for now as reporting user has been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants