Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments Title: Count toggle working in 'Singular' editing mode #40541

Closed
jameskoster opened this issue Apr 22, 2022 · 1 comment · Fixed by #40728
Closed

Comments Title: Count toggle working in 'Singular' editing mode #40541

jameskoster opened this issue Apr 22, 2022 · 1 comment · Fixed by #40728
Assignees
@cbravobernal
Labels
[Block] Comments Title Affects the Comments Title Block [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

Best explained with a video:

comments-title.mp4
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Block] Comments Title Affects the Comments Title Block labels Apr 22, 2022
@cbravobernal cbravobernal self-assigned this Apr 29, 2022
@cbravobernal
Copy link
Contributor

I'm thinking about the best way to approach this fix and, as 'One response' is a just placeholder sentence, editable, which option could be better?

  • Add different placeholder depending on Show Comments Count (One response vs Response or whatever word). We would add a new string (we are in string freeze), and we would just change the default placeholder regarding showing the comment or not.
  • Hide "Show comments Count" if Singular mode is enabled.

What do you think @jameskoster ?

I guess the first option is easier for UX, but I cannot find any word for a singular title with no comments count right now 😅

cc: @carolinan @paaljoachim @justintadlock

@cbravobernal cbravobernal mentioned this issue Apr 29, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 29, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbravobernal cbravobernal

Labels
[Block] Comments Title Affects the Comments Title Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Comments Title: Count toggle working in 'Singular' editing mode (fix) WordPress/gutenberg
3 participants
@jameskoster @priethor @cbravobernal