Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed "More Options" in Block Toolbar for Embed blocks #27339

Closed
bph opened this issue Nov 27, 2020 · 3 comments · Fixed by #27733
Closed

changed "More Options" in Block Toolbar for Embed blocks #27339

bph opened this issue Nov 27, 2020 · 3 comments · Fixed by #27733
Labels
[Block] Embed Affects the Embed Block [Type] Question Questions about the design or development of the editor.

Comments

@bph
Copy link
Contributor

bph commented Nov 27, 2020

Prior to WordPress 5.6 the Embed blocks had the following More Options

  • Hide Block Settings
  • Copy
  • Duplicate
  • Insert Before
  • Insert After
  • move to
  • Edit as HTML
  • Add to Reusable blocks
  • Group
  • Remove Block

more options

The new version is missing a few of the options:

  • Hide Block Settings
  • Copy
  • Duplicate
  • Insert Before
  • Insert After
  • move to
  • Group
  • Remove Block

Screen Shot 2020-11-27 at 11 14 23 AM

These options are missing

  • Edit as HTML
  • Add to Reusable blocks

My question: What was the reasoning behind it these changes? Is there an alternative way to access these features?

The reason for my inquiry is: On the Documentation team for Block Editor end user, we decided to make More Options a separate page and not have those options repeated on every single block documentation page. Until now, the More Options were uniform. If this those two options were deliberately omitted, we would need to be a bit more specific on the changes to the menu for Embed blocks

@bph bph added [Type] Question Questions about the design or development of the editor. [Block] Embed Affects the Embed Block labels Nov 27, 2020
@ntsekouras
Copy link
Contributor

Hey @bph - thanks for reporting this!

This was introduced in the PR to make embeds block variation: #24090.
It was a mistake of mine that has slipped..

I've created a new PR to add the support for html and reusable back here: #27733

FYI there is still an open issue for embeds in front-end: #14608.

Regarding the documentation these two features/options are available through supports option.
Reference: https://developer.wordpress.org/block-editor/developers/block-api/block-supports/

@bph
Copy link
Contributor Author

bph commented Dec 15, 2020

Thank you, Nik @ntsekouras for letting us know.

Once the PR is merged, would it also be marked to be added to a 5.6.1 WordPress release? It would be great if we wouldn't have to wait until March for this to be consistent again. This might be a @youknowriad question, though.

We were just ready to take the "More Options" menu out of the block documentation on many pages and link to one page for it, and it would be helpful if we wouldn't have to keep track to this for the Embed between two versions. We can, of course, if it's not feasible to port this back to core before WP 5.7

@ntsekouras
Copy link
Contributor

I'll add the backport label in the PR to be checked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants