Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting Default Style in Button block doesn't make post dirty #26716

Closed
Tracked by #32400
noisysocks opened this issue Nov 5, 2020 · 2 comments
Closed
Tracked by #32400

Setting Default Style in Button block doesn't make post dirty #26716

noisysocks opened this issue Nov 5, 2020 · 2 comments
Labels
[Block] Buttons Affects the Buttons Block [Block] Image Affects the Image Block [Block] Table Affects the Table Block [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

From https://core.trac.wordpress.org/ticket/48750.

When I change the Default style of the button after the update button still Disabled.

if change other properties after the update button enabled but not updated button's Default style value.

edit the same post in another browser or private browser and Button Default style value appear as Not Set.

button-default-style-issue
@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Block] Buttons Affects the Buttons Block labels Nov 5, 2020
@noisysocks
Copy link
Member Author

According to the reporter in the ticket this also affects the Image and Table blocks.

@noisysocks noisysocks added [Block] Image Affects the Image Block [Block] Table Affects the Table Block labels Nov 5, 2020
@talldan talldan added the [Feature] Theme Style Variations Related to style variations provided by block themes label Feb 4, 2021
This was referenced Jun 2, 2021
Open
Open
@jasmussen
Copy link
Contributor

I'm seeing this solved in trunk:
dirty

Is this one good to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Buttons Affects the Buttons Block [Block] Image Affects the Image Block [Block] Table Affects the Table Block [Feature] Theme Style Variations Related to style variations provided by block themes [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noisysocks @talldan @jasmussen