Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies with G2 select/focus states #23718

Closed
richtabor opened this issue Jul 6, 2020 · 3 comments · Fixed by #33084
Closed

Inconsistencies with G2 select/focus states #23718

richtabor opened this issue Jul 6, 2020 · 3 comments · Fixed by #33084
Assignees
@jasmussen @noahshrader
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@richtabor
Copy link
Member

I was testing the latest G2 styling and came up with a few small inconsistencies with focus/select states (border widths and radius) on items (screenshots below). I'm thinking we should have consistent border widths, colors and radii. Thoughts?

Screen Shot 2020-07-06 at 1 19 13 PM

Screen Shot 2020-07-06 at 1 19 07 PM

Screen Shot 2020-07-06 at 1 19 35 PM

Screen Shot 2020-07-06 at 1 33 25 PM

Screen Shot 2020-07-06 at 1 33 19 PM
@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Jul 6, 2020
@noahshrader noahshrader self-assigned this Jul 16, 2020
@noahshrader
Copy link
Contributor

noahshrader commented Jul 16, 2020 •
edited
Loading

@richtabor Great finds! Seeing these also, though they're slightly different from yours. Mind providing the browser you're using in those screenshots, as well as the operating system you're on? Also, is this on retina display?

@richtabor
Copy link
Member Author

Hey @noahshrader. These are from Safari on a 6k display.

@mtias mtias added the [Feature] UI Components Impacts or related to the UI component system label Aug 29, 2020
@Mamaduka
Copy link
Member

Probably fixed via #27968.

@jasmussen jasmussen mentioned this issue Jun 30, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

@noahshrader noahshrader

Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix slash command focus style. WordPress/gutenberg
5 participants
@Mamaduka @mtias @jasmussen @richtabor @noahshrader