-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Consider replacing node-sass
with Dart SASS
#22729
Comments
This might be another use case for using the npm alias feature: |
Another issue is that, to be able to use the... @use directive, Dart Sass is the only choice :
But @import is deprecated...
The post that helped me understand why my perfectly valid SCSS didn't work when in the block scaffold: According to its author, only the sass package works and not the (seemingly outdated) dart-sass one. |
@gziolo Should this still have the [Status] In Progress label even though it's closed? The latest version of |
It was fixed but we didn't publish to npm yet. It's planned for next week. Is this status confusing. I think we never remove |
Removing the |
@annezazu, can we include it in one of the project management issues you recently created? 😃 |
Great idea. I'll open one up now! |
Adding to the confusion (at least, for me) is that the npm release does not always include all closed issues at that time. For example, this issue was closed on Oct 28. When I saw a new npm release on Oct 30, I wrongly assumed that this issue would be fixed there. It took me a while to find out it was not and that I should look at the written changelog instead of the commit history. Once you know this, it is logical, but we might make this more clear for people like me who do not have much insight in the whole release process. |
Description
Related to #21730 that added support for CSS imports in JavaScript files to
start
andbuild
scripts in@wordpress/scripts
package.In #21730 (comment), @aduth raised the following issue related to
node-sass
package used:Indeed, we had many reports when people struggled with this package when upgrading Node.js version because it requires compilation.
@yscik suggested the following:
If we decide to go this route, we should ensure we use the same approach in Gutenberg project consistently.
The text was updated successfully, but these errors were encountered: