Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full site editing: Template parts editing and saving #20304

Closed
mapk opened this issue Feb 18, 2020 · 15 comments
Closed

Full site editing: Template parts editing and saving #20304

mapk opened this issue Feb 18, 2020 · 15 comments
Assignees
Labels
Needs Design Feedback Needs general design feedback.

Comments

@mapk
Copy link
Contributor

mapk commented Feb 18, 2020

With the merging of #19203 (template parts) and #18029 (multi-entity saving) we should iterate on the UX behind these initial explorations.

Editing and Saving Template-parts

A template-part is a global block that effects all pages on a site. It is often recognized as a Header, Footer, or Sidebar. When a change is made on a template-part it affects all pages/posts that include that template-part.

User journey
As a user, I'd like to edit the navigation block in my header and save it, essentially updating across all pages on my site.

Features

  • Allow editing of nested blocks.
  • Introduce various template-part layouts that can be swapped with the current layout.
  • Communicate to the user what is being saved and how it affects their site (ei. global change).
@mapk mapk added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Feature] Full Site Editing labels Feb 18, 2020
@mapk
Copy link
Contributor Author

mapk commented Feb 18, 2020

Looks like this is related to: #19886

@mapk
Copy link
Contributor Author

mapk commented Feb 18, 2020

Following the user journey stated above:

template-parts 2020-02-18 14_22_21

@mapk mapk removed the Needs Design Needs design efforts. label Feb 18, 2020
@johnstonphilip
Copy link
Contributor

I've seen that pop-up confirmation in a few places with FSE, and I find it really confusing. I also don't expect that people will actually read what is presented there without just clicking "Continue".

In my opinion, the need for this pop-up is a sign that this interface might be doing too much.

@folletto
Copy link
Contributor

What if we explore solutions that instead of a popup, are contained in the sidebar? The attention of the user is already there, so if we keep it there, then it should be easier to design a working solution instead of bouncing them back and forth on the screen?

@johnstonphilip
Copy link
Contributor

@folletto I just had another thought on a flow that I posted here: #19886 (comment)

@folletto
Copy link
Contributor

Yes, that seems going in a similar direction.

@mapk
Copy link
Contributor Author

mapk commented Feb 19, 2020

So right now, the pre-publish sidebar can be turned off by the user. My proposal to include the changes there is already going to require some modifications to be done to the sidebar so that it is persistent no matter what. I think that's okay.

Keeping them in the sidebar for the final confirmation sounds quite reasonable too. Definitely worth an exploration.

@mapk
Copy link
Contributor Author

mapk commented Feb 19, 2020

If the sidebar is the solution... we're going to need to figure out a better approach to those Publish buttons. 😆 I just won't allow a third Publish button to occur.

@MichaelArestad MichaelArestad added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Mar 5, 2020
@mapk
Copy link
Contributor Author

mapk commented Mar 12, 2020

Related: #20421

@dwolfe dwolfe self-assigned this Mar 12, 2020
@MichaelArestad
Copy link
Contributor

Reposting from #20421

Another iteration (riffing off @shaunandrews) that utilizes a sidebar (notably not pre-publish).

Try out the Prototype.

multi-entity-5b

Screenshots

image

image

image

Notes

  • Can highlight the content on desktop at full size. On mobile will likely need to resort to something similar to the template preview.
  • Similar to the default save flow (is not pre-publish)
  • Is a good path to save specific part changes, duplicate template parts, discard changes

Source Figma document

@MichaelArestad MichaelArestad added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Mar 19, 2020
@joanrho
Copy link
Contributor

joanrho commented Apr 8, 2020

Hey @MichaelArestad!

Would you like feedback on the design mocks you posted above or the direction (screenshotted below) from your source Figma file > page: Prototype i3? The latter seems to introduce checkboxes...?

Screen Shot 2020-04-08 at 4 30 06 PM

@MichaelArestad
Copy link
Contributor

@joanrho The latter. I posted the update to that here (to keep feedback in one place):

#20421 (comment)

It also doesn't introduce the checkbox component. Those already exist as mocked up in Gutenberg. (Though I think they could use a tiny bit more iteration)

@mapk
Copy link
Contributor Author

mapk commented Apr 14, 2020

I really like

  1. The "Cancel" button is a great addition and makes it clear how to escape this flow.
  2. Keeping the "Preview" option visible and actionable is smart. I can see a flow where the user would like to double-check alternative screen previews before publishing.
  3. Hiding the various entities that need saving keeps the UI clean. But allowing power users the ability to access the list is perfect.
  4. Showing the "Save as..." as a link helps separate it from the "Save" and "Cancel" buttons up top.

Feedback

  1. The text changes once I click on "Review changes". Maybe it should remain and the Review changes can work like an accordion? Swapping out the text here could go unseen.
  2. The "save as" link is a bit long when including the template name. Maybe it should just read, "Save as..." ?
  3. What happens if I click out of the sidebar without clicking any of the buttons? Is it like clicking "Cancel"? I ask because all the other buttons on the page look like they are still active.

@MichaelArestad
Copy link
Contributor

What happens if I click out of the sidebar without clicking any of the buttons? Is it like clicking "Cancel"? I ask because all the other buttons on the page look like they are still active.

I would assume the same mechanics as prepublish, which, are that it doesn't cancel the flow. In fact, it lets the user continue editing. I am not against changing this behavior, but it's def in the realm of a separate issue.

@mapk
Copy link
Contributor Author

mapk commented Apr 28, 2020

Closing this in favor of #20421

@mapk mapk closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

6 participants